Dissolve in version 1.63

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Dissolve in version 1.63

Johan Doré

Dear Boost Geometry

 

I thought I should give it a try in 1.63 to see if some of your other contributions helped on the below described dissolve problem

 

Unfortunately 1.63 produces the same error.

 

Is there anything I can do to propel a solution for this, keeping in mind that I am far from being a boost::geometry programmer

 

Best regards

 

Johan

 

 

From: Geometry [[hidden email]] On Behalf Of Johan Doré
Sent: Sunday, September 18, 2016 21:30
To: Boost.Geometry library mailing list <[hidden email]>
Subject: [geometry] Dissolve in version 1.61

 

Dear Boost::Geometry

 

I am sorry that it took so long but I now tried the latest “develop” branch available on GitHub of the geometry library.

 

Maybe I am doing something wrong, but a lot of my test cases around the boost::geometry::dissolve function seem to fail now.

 

E.g if I try this polygon<point_xy<float>> Input containing the points:

       0.0000000000000000           1.0000000000000000

       1.0000000000000000           0.0000000000000000

       1.0000000000000000           1.0000000000000000

       0.0000000000000000           0.0000000000000000

       0.0000000000000000           1.0000000000000000

 

The following call to dissolve:

  multi_polygon<polygon<point_xy<float>>> Dissolved;

  boost::geometry::dissolve(Input, Dissolved);

 

just returns an empty Dissolved multi_polygon

 

Is there anything which I can be doing wrong?

 

Best regards, and as always thanks for your great work

 

Johan

 

From: Geometry [[hidden email]] On Behalf Of Johan Doré
Sent: Tuesday, August 9, 2016 10:46
To: Boost.Geometry library mailing list <
[hidden email]>
Subject: Re: [geometry] Dissolve in version 1.61

 

Hi Barend,

 

Great, I’ll give it a try shortly.

 

Thanks a lot

 

Johan

 

From: Geometry [[hidden email]] On Behalf Of Barend Gehrels
Sent: Wednesday, July 20, 2016 17:01
To: Boost.Geometry library mailing list <
[hidden email]>
Subject: Re: [geometry] Dissolve in version 1.61

 

Hi Johan,

Sorry for the late response. Indeed the dissolve extension was not compiling in 1.61

I fixed that today (for the Develop branch), so it will compile again. There are some new issues in dissolve, where output is now included twice. But it still succeeds in fixing polygons with self-intersections. So I hope it is useful for you in this state.

Regards, Barend


Op 1-7-2016 om 11:12 schreef Johan Doré:

Dear Boost Geometry,

 

I wonder if any of you have had time to figure out why the Dissolve.hpp doesn’t compile with version 1.61?

 

Best regards

 

Johan

 

From: Geometry [[hidden email]] On Behalf Of Johan Doré
Sent: Thursday, May 26, 2016 21:18
To: Boost.Geometry library mailing list
[hidden email]
Subject: [geometry] Dissolve in version 1.61

 

Dear Boost Geometry,

 

I just tried to download version 1.61. Unfortunately we are using the Dissolve function, but I cannot find a Branch or Tag in Github with a version of Dissole which compiles with version 1.61.

 

I wonder if I am looking the wrong places I it simply hasn’t made it yet?

 

Best regards

 

Johan

 


_______________________________________________
Geometry mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/geometry
Reply | Threaded
Open this post in threaded view
|

Re: Dissolve in version 1.63

Barend
Hi Johan,

Op 8-1-2017 om 18:19 schreef Johan Doré:

Dear Boost Geometry

 

I thought I should give it a try in 1.63 to see if some of your other contributions helped on the below described dissolve problem

 

Unfortunately 1.63 produces the same error.

 

Is there anything I can do to propel a solution for this, keeping in mind that I am far from being a boost::geometry programmer


Sorry for my delays in answers. Yes, indeed, the errors are not fixed. Please note (but you know) that dissolve is an extension and not officially maintained. Due to works in underlying code, and some changes in underlying concepts, the algorithm does not work anymore for some cases that were supported before.

We're working on validity of geometries, and after that the rescaling (which is used internally for overlay operations) will be adapted or removed completely. That might also cause some differences. After that I will try to fix dissolve again in the state it was before (and maybe even better, in the end it should once be released). But doing it now is not possible.

Sorry for the inconvenience.

Best regards, Barend


 

 

From: Geometry [[hidden email]] On Behalf Of Johan Doré
Sent: Sunday, September 18, 2016 21:30
To: Boost.Geometry library mailing list <[hidden email]>
Subject: [geometry] Dissolve in version 1.61

 

Dear Boost::Geometry

 

I am sorry that it took so long but I now tried the latest “develop” branch available on GitHub of the geometry library.

 

Maybe I am doing something wrong, but a lot of my test cases around the boost::geometry::dissolve function seem to fail now.

 

E.g if I try this polygon<point_xy<float>> Input containing the points:

       0.0000000000000000           1.0000000000000000

       1.0000000000000000           0.0000000000000000

       1.0000000000000000           1.0000000000000000

       0.0000000000000000           0.0000000000000000

       0.0000000000000000           1.0000000000000000

 

The following call to dissolve:

  multi_polygon<polygon<point_xy<float>>> Dissolved;

  boost::geometry::dissolve(Input, Dissolved);

 

just returns an empty Dissolved multi_polygon

 

Is there anything which I can be doing wrong?

 

Best regards, and as always thanks for your great work

 

Johan

 



_______________________________________________
Geometry mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/geometry
Reply | Threaded
Open this post in threaded view
|

Re: Dissolve in version 1.63

Johan Doré

Dear Barend,

 

Thanks for the update. I completely understand and wait patiently.

 

Best regards

 

Johan

 

 

From: Geometry [mailto:[hidden email]] On Behalf Of Barend Gehrels
Sent: Monday, January 9, 2017 17:54
To: Boost.Geometry library mailing list <[hidden email]>
Subject: Re: [geometry] Dissolve in version 1.63

 

Hi Johan,

Op 8-1-2017 om 18:19 schreef Johan Doré:

Dear Boost Geometry

 

I thought I should give it a try in 1.63 to see if some of your other contributions helped on the below described dissolve problem

 

Unfortunately 1.63 produces the same error.

 

Is there anything I can do to propel a solution for this, keeping in mind that I am far from being a boost::geometry programmer


Sorry for my delays in answers. Yes, indeed, the errors are not fixed. Please note (but you know) that dissolve is an extension and not officially maintained. Due to works in underlying code, and some changes in underlying concepts, the algorithm does not work anymore for some cases that were supported before.

We're working on validity of geometries, and after that the rescaling (which is used internally for overlay operations) will be adapted or removed completely. That might also cause some differences. After that I will try to fix dissolve again in the state it was before (and maybe even better, in the end it should once be released). But doing it now is not possible.

Sorry for the inconvenience.

Best regards, Barend



 

 

From: Geometry [[hidden email]] On Behalf Of Johan Doré
Sent: Sunday, September 18, 2016 21:30
To: Boost.Geometry library mailing list <[hidden email]>
Subject: [geometry] Dissolve in version 1.61

 

Dear Boost::Geometry

 

I am sorry that it took so long but I now tried the latest “develop” branch available on GitHub of the geometry library.

 

Maybe I am doing something wrong, but a lot of my test cases around the boost::geometry::dissolve function seem to fail now.

 

E.g if I try this polygon<point_xy<float>> Input containing the points:

       0.0000000000000000           1.0000000000000000

       1.0000000000000000           0.0000000000000000

       1.0000000000000000           1.0000000000000000

       0.0000000000000000           0.0000000000000000

       0.0000000000000000           1.0000000000000000

 

The following call to dissolve:

  multi_polygon<polygon<point_xy<float>>> Dissolved;

  boost::geometry::dissolve(Input, Dissolved);

 

just returns an empty Dissolved multi_polygon

 

Is there anything which I can be doing wrong?

 

Best regards, and as always thanks for your great work

 

Johan

 

 


_______________________________________________
Geometry mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/geometry
Reply | Threaded
Open this post in threaded view
|

Re: Dissolve in version 1.63

Boost Geometry mailing list

Dear Boost Geometry

 

I was just trying the latest boost 1.64 with the Geometry extension from your develop branch, to see if there was a chance that your updates to the dissolve algorithm has helped on the issues I reporter earlier.

 

Dissolve.h however doesn’t compile and is complaining:

 

1>C:\Program Files (x86)\Boost\Boost_1_64_0\boost/geometry/extensions/algorithms/dissolve.hpp(226): error C2780: 'void boost::geometry::detail::overlay::get_ring_turn_info(TurnInfoMap &,const Turns &,const Clusters &)' : expects 3 arguments - 2 provided

 

So I wonder if I am doing something wrong or I simply caught the branch at a bad moment?

 

Best regards

 

Johan


_______________________________________________
Geometry mailing list
[hidden email]
https://lists.boost.org/mailman/listinfo.cgi/geometry
Reply | Threaded
Open this post in threaded view
|

Re: Dissolve in version 1.63

Boost Geometry mailing list
Hi Johan,



Op 11-6-2017 om 20:29 schreef Johan Doré via Geometry:

Dear Boost Geometry

 

I was just trying the latest boost 1.64 with the Geometry extension from your develop branch, to see if there was a chance that your updates to the dissolve algorithm has helped on the issues I reporter earlier.

 

Dissolve.h however doesn’t compile and is complaining:

 

1>C:\Program Files (x86)\Boost\Boost_1_64_0\boost/geometry/extensions/algorithms/dissolve.hpp(226): error C2780: 'void boost::geometry::detail::overlay::get_ring_turn_info(TurnInfoMap &,const Turns &,const Clusters &)' : expects 3 arguments - 2 provided

 

So I wonder if I am doing something wrong or I simply caught the branch at a bad moment?


The dissolve extension was again not updated, sorry for the inconvenience and thanks for reporting this again. It is fixed now and should work correctly with Boost 1.64 (so take the extensions from develop, as usual).

Regards, Barend


_______________________________________________
Geometry mailing list
[hidden email]
https://lists.boost.org/mailman/listinfo.cgi/geometry