bug in 07_b_graph_route_example.cpp

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

bug in 07_b_graph_route_example.cpp

Andrew Hundt
In build_route():

https://github.com/boostorg/geometry/blob/master/example/07_b_graph_route_example.cpp#L237

The ordering that is output is flipped between each add_edge_to_route call. 

I believe the correct order is:

    add_edge_to_route(graph, pred, vertex2, route);
    while (pred != vertex1)
    {
        add_edge_to_route(graph, predecessors[pred], pred, route);
        pred = predecessors[pred];
    }

This still leaves duplicate points which may be a bit wasteful but at least it doesn't seem like any steps will be backwards!

Also, I'm a little sad the github issues are gone, they are very convenient and easy to use. Should I report this under the old svn trac issues?

Cheers!
Andrew Hundt

_______________________________________________
Geometry mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/geometry
Reply | Threaded
Open this post in threaded view
|

Re: bug in 07_b_graph_route_example.cpp

Andrew Hundt


On Mon, Apr 6, 2015 at 4:53 PM, Andrew Hundt <[hidden email]> wrote:
In build_route():

https://github.com/boostorg/geometry/blob/master/example/07_b_graph_route_example.cpp#L237

The ordering that is output is flipped between each add_edge_to_route call. 

I believe the correct order is:

    add_edge_to_route(graph, pred, vertex2, route);
    while (pred != vertex1)
    {
        add_edge_to_route(graph, predecessors[pred], pred, route);
        pred = predecessors[pred];
    }

This still leaves duplicate points which may be a bit wasteful but at least it doesn't seem like any steps will be backwards!

Also, I'm a little sad the github issues are gone, they are very convenient and easy to use. Should I report this under the old svn trac issues?

I wanted to follow up on this since I haven't heard anything. 


Cheers!
Andrew Hundt

_______________________________________________
Geometry mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/geometry
Reply | Threaded
Open this post in threaded view
|

Re: bug in 07_b_graph_route_example.cpp

Menelaos Karavelas
Hi Andrew.

On 16/06/2015 09:45 μμ, Andrew Hundt wrote:


On Mon, Apr 6, 2015 at 4:53 PM, Andrew Hundt <[hidden email]> wrote:
In build_route():

https://github.com/boostorg/geometry/blob/master/example/07_b_graph_route_example.cpp#L237

The ordering that is output is flipped between each add_edge_to_route call. 

I believe the correct order is:

    add_edge_to_route(graph, pred, vertex2, route);
    while (pred != vertex1)
    {
        add_edge_to_route(graph, predecessors[pred], pred, route);
        pred = predecessors[pred];
    }

This still leaves duplicate points which may be a bit wasteful but at least it doesn't seem like any steps will be backwards!

Also, I'm a little sad the github issues are gone, they are very convenient and easy to use. Should I report this under the old svn trac issues?


Issues are indeed disabled for the Boost.Geometry repository, so your only option currently is to report this in Trac.

BTW, do members of this list have an opinion about GitHub issues? Should we use them instead of Trac?

- m.

I wanted to follow up on this since I haven't heard anything. 


Cheers!
Andrew Hundt


_______________________________________________
Geometry mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/geometry


_______________________________________________
Geometry mailing list
[hidden email]
http://lists.boost.org/mailman/listinfo.cgi/geometry